Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sponsor): non-i18n content adjustment #572

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

wanyewei
Copy link
Contributor

@wanyewei wanyewei commented Aug 18, 2024

Types of changes

  • Refactoring

Description

Remove content that does not require i18n conversion.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Into pages/sponsor/index.vue
  2. Check line 54 in index.vue if $t('terms.contact') become sponsorship@python.tw or not
  3. Into i18n/sposor/index.i18n.js
  4. Check if terms: {contact: 'sponsorship@python.tw', } has been removed from both en-us and zh-hant in index.i18n.js.
  5. Into http://localhost:3000/2024/en-us/sponsor
  6. Check if sponsorship@python.tw showed normally or not

Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
🔨 Latest commit 2757a61
🔍 Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/66d2c10c930e1d000853e898
😎 Deploy Preview https://deploy-preview-572--classy-granita-bc2b5a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit 2757a61
🔍 Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/66d2c10cb9d1f60008f299d3
😎 Deploy Preview https://deploy-preview-572--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wanyewei wanyewei requested a review from SivanYeh August 18, 2024 12:54
@SivanYeh
Copy link
Collaborator

index.vue上把{{ $t('terms.contact') }}取代成sponsorship@python.tw的調整方向確實對了。
但超連結的效果卻消失了,思考一下大概是什麼原因(hint: 跟你index.i18n.js調整有關

可以參考一下privacy-policytickets上對organizers@python.tw的處理方法

Copy link
Collaborator

@SivanYeh SivanYeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SivanYeh SivanYeh merged commit 4f658a7 into main Aug 31, 2024
9 checks passed
@SivanYeh SivanYeh deleted the chor---Non-i18n-content-rearrangement branch August 31, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants